Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor setting TargetFrameworks #1488

Merged
merged 9 commits into from
Oct 24, 2022
Merged

Refactor setting TargetFrameworks #1488

merged 9 commits into from
Oct 24, 2022

Conversation

pellared
Copy link
Member

@pellared pellared commented Oct 24, 2022 •
edited
Loading

Why

  • Remove duplication 😉 It should reduce the risk of a bug when introducing support for new .NET version.
  • Change the order so that VS Code targets .NET 6.0 (or .NET Core 3.1) by default

What

Refactor setting TargetFrameworks

Tests

CI

@pellared pellared requested a review from a team October 24, 2022 09:53
@pellared pellared enabled auto-merge (squash) October 24, 2022 09:58
@pellared pellared disabled auto-merge October 24, 2022 10:01
@pellared pellared enabled auto-merge (squash) October 24, 2022 10:06
@pellared pellared merged commit f956dfd into open-telemetry:main Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kielek Kielek Kielek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pellared @Kielek