Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename artifact to opentelemetry-exporter-sender-okhttp #5582

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

jack-berg
Copy link
Member

Related to #5572. Talked about in the 6/29 java SIG and agreed that we should rename the new okhttp http sender artifact to opentelemetry-exporter-sender-okhttp to reduce artifact churn when the scope is expanded to include a GrpcSender implementation.

@jack-berg jack-berg requested a review from a team June 29, 2023 18:38
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (83de956) 91.35% compared to head (ef1ac84) 91.35%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5582   +/-   ##
=========================================
  Coverage     91.35%   91.35%           
  Complexity     4969     4969           
=========================================
  Files           552      552           
  Lines         14581    14581           
  Branches       1358     1358           
=========================================
  Hits          13320    13320           
  Misses          872      872           
  Partials        389      389           
Impacted Files Coverage Δ
...ry/exporter/internal/http/HttpExporterBuilder.java 92.15% <ø> (ø)
...orter/sender/okhttp/internal/OkHttpHttpSender.java 98.43% <ø> (ø)
...nder/okhttp/internal/OkHttpHttpSenderProvider.java 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jack-berg jack-berg merged commit 06d2656 into open-telemetry:main Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants