-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds on_ending callback to allow processors to mutate spans before End operation #1713
Merged
mwear
merged 11 commits into
open-telemetry:main
from
pantuza:span-processor-on-ending-interface
Oct 1, 2024
Merged
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
90b2c85
feature: adds on_ending method as an optional callback for span proce…
pantuza 93e6d9f
feature: calls every span processor that has on_ending implemented ri…
pantuza 0f1cf16
test: adds tests for the new on_ending method from span processors
pantuza e1c7cc3
Merge branch 'main' of github.com:open-telemetry/opentelemetry-ruby i…
pantuza 2c28b76
docs: Informs the on_ending callback is an experimental features from…
pantuza 9d9c944
Update sdk/lib/opentelemetry/sdk/trace/span_processor.rb
pantuza 173e57a
Update sdk/lib/opentelemetry/sdk/trace/span_processor.rb
pantuza a2802af
Merge branch 'main' of github.com:open-telemetry/opentelemetry-ruby i…
pantuza fe7c455
Merge branch 'span-processor-on-ending-interface' of github.com:pantu…
pantuza c9bb0f5
Merge branch 'main' of github.com:open-telemetry/opentelemetry-ruby i…
pantuza fc085c3
refactor: switch method name from on_ending to on_finish to comply wi…
pantuza File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an experimental feature and may have breaking changes. How about specifying that here ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the suggestion. I will update it.