Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Followup updates to #989 #1004

Closed
wants to merge 1 commit into from
Closed

Conversation

hdost
Copy link
Contributor

@hdost hdost commented Mar 23, 2023

No description provided.

@hdost hdost requested a review from a team March 23, 2023 19:00
@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (7d56e91) 69.9% compared to head (3117488) 69.9%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1004   +/-   ##
=====================================
  Coverage   69.9%   69.9%           
=====================================
  Files        116     116           
  Lines       9027    9027           
=====================================
  Hits        6316    6316           
  Misses      2711    2711           
Impacted Files Coverage Δ
...elemetry-sdk/src/export/metrics/aggregation/mod.rs 53.3% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hdost
Copy link
Contributor Author

hdost commented Mar 23, 2023

Abandoning until #1000 merged

@hdost hdost marked this pull request as draft March 23, 2023 20:40
@jtescher
Copy link
Member

Think we can close this now as the file has been removed

@jtescher jtescher closed this Apr 23, 2023
@hdost hdost deleted the followup-989 branch May 2, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants