Assign view paired #324
Assign view paired #324
Conversation
|
[Whoops accidentally based this on the branch for https://github.com//pull/322...] |
|
Tests fail for test_expected, and I haven't touched any of that... |
|
My PR fixes that, but hasn't been merged in since numba iterative
correction isn't working (& hence eig_trans test) in python 3.9
…On Fri, Feb 4, 2022, 8:33 AM Ilya Flyamer ***@***.***> wrote:
Tests fail for test_expected, and I haven't touched any of that...
—
Reply to this email directly, view it on GitHub
<#324 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEV7GZNMVANKAJQIN27VQZLUZP5WBANCNFSM5MNHSRLA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
Rename function to assign_view_paired. |
| cols_view=cols_view, | ||
| ) | ||
| features[cols_right[1:]] = features[cols_right[1:]].astype( | ||
| int |
There was a problem hiding this comment.
can you check if this cast is needed for the final output - i.e. for after the second assign_view application ? just in case (also is it an expected behavior on bioframe side of things ? issue-worthy or not ?)
There was a problem hiding this comment.
This is because the df start off with numpy int dtypes, and then bioframe converts the other columns to numpy float64. But if it is pd.Int64Dtype from the beginning, this cast is not necessary.
In the second run of assign_view the cols_right[1:] get cast to pd.Int64Dtype, and the other ones are already that from this first cast... It's confusing. But the second cast is not necessary.
I don't know if this should be an issue in bioframe, I remember extended discussions about dtypes there and I think we couldn't find a way to avoid this sort of weird casting...
Created a function to assign view to a bedpe-style dataframe, to be used in snipping and dotcaller. Still need to actually replace the deprecated function.
Aims to close #251