Merge pull request #811 from opentable/DX-363

[DX-363] Registry conf.env sanitizer
opencomponents · Jan 24, 2018 · 62274bd · 62274bd
2 parents a5ba06e + a839eee
commit 62274bd
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/src/registry/domain/options-sanitiser.js b/src/registry/domain/options-sanitiser.js
@@ -77,5 +77,9 @@ module.exports = function(input) {
     options.storage.options.verbosity = options.verbosity;
   }
 
+  if (!options.env) {
+    options.env = {};
+  }
+
   return options;
 };
diff --git a/test/unit/registry-domain-options-sanitiser.js b/test/unit/registry-domain-options-sanitiser.js
@@ -120,4 +120,20 @@ describe('registry : domain : options-sanitiser', () => {
       });
     });
   });
+
+  describe('when env', () => {
+    describe('is provided', () => {
+      const options = { baseUrl: 'dummy', env: { value: 'test' } };
+      it('should not modify it', () => {
+        expect(sanitise(options).env).to.deep.equal({ value: 'test' });
+      });
+    });
+
+    describe('is not provided', () => {
+      const options = { baseUrl: 'dummy' };
+      it('should initialize it as an empty {}', () => {
+        expect(sanitise(options).env).to.deep.equal({});
+      });
+    });
+  });
 });