Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make OC browser client AMD compatible #226

Closed
matteofigus opened this issue Apr 7, 2016 · 5 comments
Closed

Make OC browser client AMD compatible #226

matteofigus opened this issue Apr 7, 2016 · 5 comments

Comments

@matteofigus
Copy link
Member

So that it can be used with any AMD loader

@Hobbit71
Copy link

+1 from me for this

@matteofigus
Copy link
Member Author

Not sure I have so much time for working on this. Would you be able to help @Hobbit71?
Or perhaps @nickbalestra / @mattiaerre / @tpgmartin ?

@Hobbit71
Copy link

Let me fork the code and take a look @matteofigus. Will see if I can do it over the weekend.

@matteofigus
Copy link
Member Author

matteofigus commented May 20, 2016

Thanks @Hobbit71. The code is mostly here.
The grunt test-local task should run the tests for that and grunt build should build the package.
Let me know if you have any issues.
I think that piece of code kind of works but would need some love to be cleaned up a bit 👍

@Hobbit71
Copy link

Thanks @matteofigus for the info, already got the code in front of me. Will ping you if I hit anything major. Looking good so far.

matteofigus added a commit that referenced this issue May 23, 2016
* updated to support define

* issue #226 - initial factor to make AMD and CommonJS complient
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants