-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cli argument to skip dependencies packaging #769
Comments
If I start working on it I'd assign it to me. Until then, I leave it open for others to collaborate. |
So, given we have an |
I don't know the internals like you, so I guess your argument will probably fit better than mine :_D |
@elboletaire look at @NimaSoroush's PR that we just merged. Sounds like very similar but for packaging (skips install and does symlinking) #971 |
Thanks @matteofigus. Thing is I wasn't able to dedicate more time to this since last time, but I'll look into it as soon as I've time again 😃 |
I was thinking on taking on this issue and I think there's 3 use cases to consider when doing this new command. 1. Mirroring what publish does on the same component
In this case the scenario is you have your component, you package first, it creates the 2. Publishing the folder itself
In this case, the component is already gone, as we only stored the artifact of the package to be deployed/published at a later stage. So here the CLI will see that there's no _package folder inside of your path, so will try to find a package.json inside, and if there is one, check that we are on a compiled package (checking that theres an 3. Publishing a compressed file
Similar to the case 2 but here we also compress and we want to publish that file. In this case I don't see the point of skipping package, since CLI could already assume that if the path is of a compressed file, you just want to publish that. Does this approach make sense? |
In some scenarios people tend to compile dependencies by their own before doing
oc publish
, so let's add a cli argument, something like--skip-dependencies
or--skip-build
, to allow us skip the dependencies installation later again via oc.The text was updated successfully, but these errors were encountered: