Add cli argument to skip dependencies packaging #1191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbazydlo
reviewed
Aug 16, 2021
pbazydlo
approved these changes
Aug 16, 2021
pbazydlo
approved these changes
Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #769
This makes it possible to directly publish an already packaged component. Of the 3 possible ways referenced on the issue I just did the first approach, which I guess is the more natural given the current flow of what publishing does, which is to to skip the packaging (creating the _package folder) and do the rest the same.
So
oc publish --skipPackage your-componentWill try to find a
_packagefolder inyour-componentfolder and publish it. It will fail with an error message if either the _package folder does not exist, or there isn't a package.json file inside (needed to get component info).This helps for cases where you package/build it yourself to publish on a later stage (without needing to store all the dependencies needed for the bundling process).