Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean eslint rule warnings/errors #1196

Merged

Conversation

ricardo-devis-agullo
Copy link
Collaborator

@ricardo-devis-agullo ricardo-devis-agullo commented Aug 21, 2021

This is just a cleanup of code following eslint errors/warnings present. Some notes:

  1. There's still two warnings about use of console. I left them since I'm not sure if they are a problem or not (they were two more but those I added an exception rule since they are on logger files, so makes sense they reference console.log)
  2. I disabled no-confusing-arrow. Trying to refactor it would conflict with the also enabled rule arrow-body-style to not have a body where you only return, so I decided to remove the first one since there's not a lot of cases anyways.
  3. I removed two TODO (per eslint rule) about adding logger and watch to the compiler, but added and issue about it (not going to reference it so it doesn't get closed when merging this)

@ricardo-devis-agullo ricardo-devis-agullo merged commit 788b821 into opencomponents:master Aug 24, 2021
@ricardo-devis-agullo ricardo-devis-agullo deleted the eslint-clean branch August 24, 2021 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants