clean eslint rule warnings/errors #1196
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a cleanup of code following eslint errors/warnings present. Some notes:
logger
files, so makes sense they reference console.log)no-confusing-arrow
. Trying to refactor it would conflict with the also enabled rulearrow-body-style
to not have a body where you only return, so I decided to remove the first one since there's not a lot of cases anyways.logger
andwatch
to the compiler, but added and issue about it (not going to reference it so it doesn't get closed when merging this)