Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Add back --prefix when installing dependencies #1262

Merged
merged 1 commit into from
Oct 21, 2021

Conversation

ricardo-devis-agullo
Copy link
Collaborator

@ricardo-devis-agullo ricardo-devis-agullo commented Oct 20, 2021

Apparently, for some reason still unknown to me, when calling publish inside a build agent, doing a npm install without the prefix may not create a node_modules folder (could not reproduce in local, but I could on Azure Devops), when you call npx oc publish on a folder that does not have a package.json.

For this reason I'm adding the option to choose whether to add the --prefix or not. It will be added when installing missing dependencies (used by publish and dev), but not when installing the template or the compiler (so it still works correctly without nesting node_modules), because installing the template will always do npm init first

@ricardo-devis-agullo ricardo-devis-agullo merged commit 27d4f3e into master Oct 21, 2021
@ricardo-devis-agullo ricardo-devis-agullo deleted the optional-prefix branch October 21, 2021 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants