[CB-INTERNAL] upgrade storage adapters and parse legacy ones #1266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbazydlo
reviewed
Oct 28, 2021
src/registry/domain/repository.ts
Outdated
| const cdn: Cdn = !conf.local && conf.storage.adapter(conf.storage.options); | ||
| const cdn: StorageAdapter = | ||
| !conf.local && | ||
| (parseAdapter(conf.storage.adapter(conf.storage.options)) as any); |
There was a problem hiding this comment.
what does parseAdapter do?
There was a problem hiding this comment.
The logic is on the new file src/registry/domain/storage-adapter.ts but what it does is check is and parse your adapter to see if it works with promises. If it does, it will just return it, if it doesnt it will universalify all its methods
There was a problem hiding this comment.
should the function be called getPromiseBasedAdapter both here and in storage-adapter.ts then?
pbazydlo
reviewed
Oct 28, 2021
| }; | ||
|
|
||
| const officialAdapters = { | ||
| s3: { name: 'oc-s3-storage-adapter', version: '1.2.0' }, |
There was a problem hiding this comment.
can we rename this version to firstPromiseBasedVersion?
pbazydlo
approved these changes
Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades to use the new storage adapters that return promises (see PR). Because users may still be using old versions of the adapters, or maybe even custom adapters that still work with callbacks, we will emit a deprecation warning and then universalify it.