[CLI-FEATURE] add registries options for oc publish #1277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbazydlo
reviewed
Nov 16, 2021
src/cli/commands.ts
Outdated
| registries: { | ||
| array: true, | ||
| description: | ||
| 'registries to publish, overriding your configuration in oc.json' |
There was a problem hiding this comment.
List of registries to publish to. This setting will take precedence over oc.json file.
pbazydlo
reviewed
Nov 16, 2021
test/unit/cli-facade-publish.js
Outdated
| @@ -101,6 +102,20 @@ describe('cli : facade : publish', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| it('should take precedence the registries set through options', done => { | |||
There was a problem hiding this comment.
should take precedence over the registries set through oc.json
pbazydlo
approved these changes
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, to publish to registries you need to have set a
oc.jsonfile with your registries. This works well when you only publish to one registry, or you always publish to all the registries at the same time (so you can have your oc.json versioned in your repo and just use it).The problem is that that solution doesn't work as well when your deployment setup is to publish to a different registry depending on your environment (1 or more registries on each environment). In that case, for every deployment, you have to go and edit the oc.json before being able to call
oc publish.For those cases, I'm adding a new option
--registriesthat allows you to pass a list of registries that will override your oc.json configuration. So when you want to publish you can just dowithout needing a oc.json