[DX-324] full async plugins initialisation #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matteofigus
commented
Dec 22, 2017
| @@ -81,27 +81,28 @@ module.exports.init = function(pluginsToRegister, callback) { | |||
| }; | |||
|
|
|||
| const loadPlugin = function(plugin, cb) { | |||
| const done = _.once(cb); | |||
There was a problem hiding this comment.
This allows robustness against plugins that would erroneously call the done() callback multiple times:
https://github.com/opencomponents/oc-hobknob/blob/master/index.js#L25
matteofigus
commented
Dec 22, 2017
| const pluginCallback = plugin.callback || _.noop; | ||
| pluginCallback(err); | ||
| registered[plugin.name] = plugin.register.execute; | ||
| done(err); |
There was a problem hiding this comment.
now the callback is called actually after the registration is completed
matteofigus
commented
Dec 22, 2017
| setTimeout(() => { | ||
| flag = true; | ||
| cb(); | ||
| }, 10); |
There was a problem hiding this comment.
With this artificial timeout, I am testing that the callback is actually called after the registration (test failed before the code change)
nickbalestra
approved these changes
Dec 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason here is an old design decision. I think that given the way plugins evolved, it makes much more sense to wait express to start after all the plugins are fully initialised.