Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Handling relative path when initiating component #941

Merged
merged 1 commit into from
Oct 5, 2018

Conversation

jankowiakmaria
Copy link
Collaborator

Not creating an issue - just a small PR that allows using relative path when initiating new component.

Why this change?

In our team all the components are in /src/components directory. All the grunt/npm tasks are defined at the top level though. When we want to create a new component it requires us to first go two levels down to do the init and then go back up to run registry locally or run the tests.

Supporting relative path would allow us to slightly reduce number of steps during the development process.

This change affects only init CLI.

Test plan (required)

Output when running node src/cli/ init test-components/hello-test
image

@matteofigus matteofigus merged commit 9d3aac0 into master Oct 5, 2018
@matteofigus matteofigus deleted the InitWithPath branch October 5, 2018 14:51
@matteofigus
Copy link
Member

Thanks @jankowiakmaria can I ask you to update the github wiki? Thanks!

@jankowiakmaria
Copy link
Collaborator Author

Thanks for merging - will have a look.

@jankowiakmaria
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants