*: get MacOS build working #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
cyphar
force-pushed
the
build-macos
branch
11 times, most recently
from
21a812d to
8dc24e4
Compare
|
Unit tests are working fine under MacOS now. I am a little worried how we'll deal with |
cyphar
force-pushed
the
build-macos
branch
4 times, most recently
from
bb6fe03 to
961ca0f
Compare
|
You can let me know if this works @IronCore864, @huntc. |
I don't have a MacOS machine (nor can we currently run the tests on
MacOS) but we can at least do a sanity-check by trying to build the
project on MacOS.
Most of the code changes move Linux-only functions (and tests) to
foo_linux{,_test}.go files, while code that was already usable on "unix"
platforms is moved to foo_unix{,_test}.go files. There was also a mild
refactor of some repeated test code, with it all being moved into
testutils. With these minor changes, umoci now builds.
Signed-off-by: Aleksa Sarai <[email protected]>
This requires a little bit of working around MacOS-specific weirdnesses (which are fine under POSIX but don't match Linux). The most obvious one is the lack of 'readlink -f', but there's also the lack of sub-second granularity of filesystem timesamps, and the default-follow behaviour of link(2) when trying to hardlink a symlink. Signed-off-by: Aleksa Sarai <[email protected]>
Signed-off-by: Aleksa Sarai <[email protected]>
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't have a MacOS machine (nor can we currently run the tests on
MacOS) but we can at least do a sanity-check by trying to build the
project on MacOS.
Fixes #98
Signed-off-by: Aleksa Sarai [email protected]