Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile: enable switching UID/GID #1047

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

pjonsson
Copy link
Contributor

@pjonsson pjonsson commented Aug 6, 2024

Add a script for switching UID/GID
of the user inside the container.
Use this to avoid making the directories
the CI uses world-writable.


📚 Documentation preview 📚: https://datacube-ows--1047.org.readthedocs.build/en/1047/

Add a script for switching UID/GID
of the user inside the container.
Use this to avoid making the directories
the CI uses world-writable.
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.63%. Comparing base (9579b4d) to head (0a7c1f5).
Report is 37 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1047   +/-   ##
=======================================
  Coverage   93.63%   93.63%           
=======================================
  Files          43       43           
  Lines        6509     6509           
=======================================
  Hits         6095     6095           
  Misses        414      414           

@pjonsson
Copy link
Contributor Author

pjonsson commented Aug 6, 2024

This PR also adds tini so zombies are reaped and signals are forwarded.

Copy link
Contributor

@SpacemanPaul SpacemanPaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks again!

@SpacemanPaul SpacemanPaul merged commit a1ab57c into opendatacube:master Aug 6, 2024
14 checks passed
@pjonsson pjonsson deleted the dockerfile-switch-uid branch August 6, 2024 22:15
pjonsson added a commit to pjonsson/datacube-ows that referenced this pull request Aug 7, 2024
Add a script for switching UID/GID
of the user inside the container.
Use this to avoid making the directories
the CI uses world-writable.
pjonsson added a commit to pjonsson/datacube-ows that referenced this pull request Aug 7, 2024
Add a script for switching UID/GID
of the user inside the container.
Use this to avoid making the directories
the CI uses world-writable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants