Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webmercator anti-meridian handling #1083

Merged
merged 14 commits into from
Nov 14, 2024
Merged

Webmercator anti-meridian handling #1083

merged 14 commits into from
Nov 14, 2024

Conversation

SpacemanPaul
Copy link
Contributor

@SpacemanPaul SpacemanPaul commented Nov 7, 2024

Appears to be working now (barring various bugs in TerriaJS).

  1. Various docker image fixes.
  2. Use datacube>=1.9-rc11 for antimeridian extent fixes.
  3. 3857 (web-merc) requests that are closer to the antimeridian than the prime meridian are reprojected to 3832 (Pacific web-merc) internally.
  4. Auto publish 3832 if 3857 is published and 3832 isn't (as 3857 now breaks for half the world if 3832 is not published).
  5. Time-zone detection is simplified - old code was too "smart" for it's own good and ended up being crazy-wrong around the antimeridian in many cases. NB. for products that are local to the Pacific/anti-meridian region, "solar" time_resolution will always behave erratically - in this case you may find "summary" time_resolution behaves more consistently.

📚 Documentation preview 📚: https://datacube-ows--1083.org.readthedocs.build/en/1083/

@SpacemanPaul SpacemanPaul marked this pull request as draft November 7, 2024 22:47
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 84.90566% with 8 lines in your changes missing coverage. Please review.

Project coverage is 93.16%. Comparing base (f298a2e) to head (b587a7f).
Report is 5 commits behind head on develop-1.9.

Files with missing lines Patch % Lines
datacube_ows/index/postgis/api.py 37.50% 5 Missing ⚠️
datacube_ows/ows_configuration.py 77.77% 2 Missing ⚠️
datacube_ows/update_ranges_impl.py 90.90% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           develop-1.9    #1083      +/-   ##
===============================================
- Coverage        93.28%   93.16%   -0.12%     
===============================================
  Files               53       53              
  Lines             7040     7056      +16     
===============================================
+ Hits              6567     6574       +7     
- Misses             473      482       +9     
Files with missing lines Coverage Δ
datacube_ows/feature_info.py 90.54% <100.00%> (ø)
datacube_ows/index/postgis/product_ranges.py 94.79% <100.00%> (+0.05%) ⬆️
datacube_ows/startup_utils.py 90.38% <100.00%> (+0.06%) ⬆️
datacube_ows/time_utils.py 90.12% <100.00%> (+5.23%) ⬆️
datacube_ows/wms_utils.py 92.55% <100.00%> (+0.10%) ⬆️
datacube_ows/update_ranges_impl.py 86.08% <90.90%> (ø)
datacube_ows/ows_configuration.py 94.08% <77.77%> (-0.15%) ⬇️
datacube_ows/index/postgis/api.py 89.24% <37.50%> (-4.94%) ⬇️

... and 2 files with indirect coverage changes

@SpacemanPaul SpacemanPaul marked this pull request as ready for review November 14, 2024 01:16
@SpacemanPaul SpacemanPaul merged commit 919a987 into develop-1.9 Nov 14, 2024
9 checks passed
@SpacemanPaul SpacemanPaul deleted the webmerc-attempt branch November 14, 2024 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants