-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add proxy fix header handling for X-Forwarded-For etc. #1085
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop-1.9 #1085 +/- ##
===============================================
- Coverage 93.33% 93.28% -0.05%
===============================================
Files 53 53
Lines 7032 7040 +8
===============================================
+ Hits 6563 6567 +4
- Misses 469 473 +4
|
@alexgleith if I understand your description, GetCapabilities will return broken results without this. Does this already work for the main branch, or should this commit also be merged there? |
Hey @pjonsson this was merged into the main branch too. |
@alexgleith are you sure about that? If I |
Nope, not sure! I think it must have been the other fix about cache-control headers that was merged into both. Happy to review a PR that adds this to the 1.8 branch. |
This is a low-risk and high-reward feature that adds another environment variable that turns on the "proxy_fix" middleware, which ensures the app understands what URLs it should return as part of the getCaps and other responses.
Tested in production for DE Pacific.
📚 Documentation preview 📚: https://datacube-ows--1085.org.readthedocs.build/en/1085/