Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort multiproduct datasets by product #837

Merged
merged 5 commits into from
Jun 22, 2022
Merged

Conversation

SpacemanPaul
Copy link
Contributor

@SpacemanPaul SpacemanPaul commented Jun 20, 2022

Sort multiproduct datasets by product (according to the order of the provided product list)

Coupled with appropriate band aliases in the ODC metadata, this allows combining products from different families (e.g. a combined Landsat/Sentinel-2 layers, with Sentinel-2 always taking precedence where available).

Further work required to support band-mapping between heterogenous products.

@codecov
Copy link

codecov bot commented Jun 20, 2022

Codecov Report

Merging #837 (68d7bf9) into master (60ac92c) will increase coverage by 0.00%.
The diff coverage is 95.23%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #837   +/-   ##
=======================================
  Coverage   93.95%   93.95%           
=======================================
  Files          43       43           
  Lines        6220     6237   +17     
=======================================
+ Hits         5844     5860   +16     
- Misses        376      377    +1     
Impacted Files Coverage Δ
datacube_ows/ows_configuration.py 96.17% <83.33%> (-0.09%) ⬇️
datacube_ows/utils.py 100.00% <100.00%> (ø)

@SpacemanPaul SpacemanPaul marked this pull request as ready for review June 22, 2022 03:52
@SpacemanPaul SpacemanPaul requested review from omad and pindge and removed request for omad and pindge June 22, 2022 03:53
@SpacemanPaul SpacemanPaul marked this pull request as draft June 22, 2022 04:32
@SpacemanPaul SpacemanPaul force-pushed the group_datasets_by_product branch from b851550 to 68d7bf9 Compare June 22, 2022 06:04
@SpacemanPaul SpacemanPaul marked this pull request as ready for review June 22, 2022 06:15
@SpacemanPaul SpacemanPaul requested review from omad and pindge June 22, 2022 06:16
@SpacemanPaul SpacemanPaul merged commit b32bdf0 into master Jun 22, 2022
@delete-merged-branch delete-merged-branch bot deleted the group_datasets_by_product branch June 22, 2022 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants