Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Isolate ops imports #855

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Isolate ops imports #855

merged 1 commit into from
Aug 4, 2022

Conversation

SpacemanPaul
Copy link
Contributor

so applications only using the styling API do not have excess dependencies.

@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #855 (95dfeae) into master (a72b69b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #855   +/-   ##
=======================================
  Coverage   93.94%   93.94%           
=======================================
  Files          43       43           
  Lines        6276     6276           
=======================================
  Hits         5896     5896           
  Misses        380      380
Impacted Files Coverage Δ
datacube_ows/startup_utils.py 93.24% <100.00%> (ø)

@SpacemanPaul SpacemanPaul marked this pull request as ready for review August 4, 2022 04:51
@SpacemanPaul SpacemanPaul requested review from pindge and emmaai August 4, 2022 04:51
emmaai
emmaai approved these changes Aug 4, 2022
View reviewed changes
Copy link

@emmaai emmaai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SpacemanPaul SpacemanPaul merged commit cfadb32 into master Aug 4, 2022
@delete-merged-branch delete-merged-branch bot deleted the isolate_sentry_import branch August 4, 2022 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmaai emmaai emmaai approved these changes

@pindge pindge Awaiting requested review from pindge

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SpacemanPaul @emmaai