Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle response crs parameter in WCS1. #858

Merged
merged 4 commits into from
Aug 26, 2022
Merged

Handle response crs parameter in WCS1. #858

merged 4 commits into from
Aug 26, 2022

Conversation

SpacemanPaul
Copy link
Contributor

@SpacemanPaul SpacemanPaul commented Aug 26, 2022 •
edited
Loading

See #857 - in fact response_crs was essentially being ignored. This patch should fix that.

@SpacemanPaul SpacemanPaul marked this pull request as ready for review August 26, 2022 06:33
@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #858 (16a311e) into master (763e356) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #858   +/-   ##
=======================================
  Coverage   93.94%   93.95%           
=======================================
  Files          43       43           
  Lines        6276     6283    +7     
=======================================
+ Hits         5896     5903    +7     
  Misses        380      380
Impacted Files Coverage Δ
datacube_ows/wcs1_utils.py 96.21% <100.00%> (+0.11%) ⬆️

@SpacemanPaul SpacemanPaul requested a review from pindge August 26, 2022 06:34
@pindge pindge merged commit ddc1b5b into master Aug 26, 2022
@delete-merged-branch delete-merged-branch bot deleted the wcs1_respsonse_crs_fix branch August 26, 2022 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pindge pindge pindge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SpacemanPaul @pindge