Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make sentry ignore geom error from shapelh #873

Merged
merged 1 commit into from
Sep 26, 2022
Merged

make sentry ignore geom error from shapelh #873

merged 1 commit into from
Sep 26, 2022

Conversation

pindge
Copy link
Contributor

@pindge pindge commented Sep 25, 2022

fixes #869

@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Merging #873 (d0d9a74) into master (21daeb2) will decrease coverage by 0.11%.
The diff coverage is 16.66%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #873      +/-   ##
==========================================
- Coverage   93.96%   93.85%   -0.12%     
==========================================
  Files          43       41       -2     
  Lines        6284     6246      -38     
==========================================
- Hits         5905     5862      -43     
- Misses        379      384       +5
Impacted Files Coverage Δ
datacube_ows/startup_utils.py 90.25% <16.66%> (-2.99%) ⬇️
datacube_ows/utils.py
datacube_ows/__init__.py

SpacemanPaul
SpacemanPaul approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@SpacemanPaul SpacemanPaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit of a hack, but effective immediate fix.

@SpacemanPaul SpacemanPaul merged commit 4c4f991 into master Sep 26, 2022
@delete-merged-branch delete-merged-branch bot deleted the sentry-filter branch September 26, 2022 22:38
@pindge pindge mentioned this pull request Sep 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SpacemanPaul SpacemanPaul SpacemanPaul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

need to setup a test case that can trigger 'LGEOS380' object has no attribute 'GEOSGeom_destroy'
2 participants
@pindge @SpacemanPaul