refine sentry ignore #884
Merged
refine sentry ignore #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #884 +/- ##
=======================================
Coverage 93.97% 93.97%
=======================================
Files 41 41
Lines 6275 6278 +3
=======================================
+ Hits 5897 5900 +3
Misses 378 378
|
jmettes
reviewed
Oct 17, 2022
.env_ows_root
Outdated
| DATACUBE_OWS_CFG=ows_refactored.ows_root_cfg.ows_cfg | ||
| SENTRY_DSN=https://[email protected]/2 |
There was a problem hiding this comment.
where does https://[email protected]/2 get set up?
There was a problem hiding this comment.
just a placeholder, i've decided to set it empty
jmettes
approved these changes
Oct 17, 2022
| class LGEOS380: | ||
| x = 5 | ||
| class LGEOS380(): | ||
| def __init__(self, a=5): |
There was a problem hiding this comment.
If you just want an empty class, you don't need an __init__. Could just do something like
class LGEOS380:
pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #869
captured error message: "'LGEOS380' object has no attribute 'GEOSGeom_destroy'"
add SENTRY_DSN to
.envfix the test case to reflect the correct reported error
GEOSGEOM_destroyhttps://github.com/shapely/shapely/blob/f02c4c72d29862ade0708ce777d0316fbba44fef/shapely/geos.py#L633
https://github.com/shapely/shapely/blob/f02c4c72d29862ade0708ce777d0316fbba44fef/shapely/geos.py#L766
https://github.com/shapely/shapely/blob/f02c4c72d29862ade0708ce777d0316fbba44fef/shapely/geos.py#L778
https://github.com/shapely/shapely/blob/f02c4c72d29862ade0708ce777d0316fbba44fef/shapely/geos.py#L790
https://github.com/shapely/shapely/blob/f02c4c72d29862ade0708ce777d0316fbba44fef/shapely/geos.py#L801