Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make FlagBands aware of band aliases on the main product(s). #887

Merged
merged 8 commits into from
Oct 19, 2022

Conversation

SpacemanPaul
Copy link
Contributor

@SpacemanPaul SpacemanPaul commented Oct 18, 2022

Still need to update docs.

I think this is the right approach but there are still some bugs to be worked through.

@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Merging #887 (761446b) into master (863802c) will decrease coverage by 0.01%.
The diff coverage is 88.23%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #887      +/-   ##
==========================================
- Coverage   93.97%   93.96%   -0.02%     
==========================================
  Files          41       41              
  Lines        6278     6292      +14     
==========================================
+ Hits         5900     5912      +12     
- Misses        378      380       +2     
Impacted Files Coverage Δ
datacube_ows/config_utils.py 95.83% <80.00%> (-0.36%) ⬇️
datacube_ows/ows_configuration.py 95.99% <100.00%> (+0.02%) ⬆️
datacube_ows/styles/ramp.py 94.72% <0.00%> (-0.02%) ⬇️

pindge
pindge previously approved these changes Oct 18, 2022
@SpacemanPaul SpacemanPaul marked this pull request as ready for review October 18, 2022 08:09
@SpacemanPaul SpacemanPaul requested review from pindge and rtaib October 18, 2022 08:10
@SpacemanPaul SpacemanPaul merged commit 248f2ec into master Oct 19, 2022
@delete-merged-branch delete-merged-branch bot deleted the band_aliases_flag_bands branch October 19, 2022 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants