Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Display oauth2 login error messages on login authorization page. #6845

Closed
adunsulag opened this issue Sep 12, 2023 · 0 comments · Fixed by #6846
Closed

bug: Display oauth2 login error messages on login authorization page. #6845

adunsulag opened this issue Sep 12, 2023 · 0 comments · Fixed by #6846
Milestone

Comments

@adunsulag
Copy link
Member

If an error occurs in the oauth2 login page (invalid credentials, user/patient doesn't exist, etc) we should display it instead of just refreshing the screen.

adunsulag added a commit to DiscoverAndChange/openemr that referenced this issue Sep 12, 2023
Made the login error messages show up - Fixes openemr#6845

Refactored the patient-select,scope-authorize,login pages into twig
files that share a twig base of oauth2-base.html.twig.  Added
PageTemplateRender events that module writers can key into / override if
they need to.

Moved the MFA script into the config.yaml so we can grab it in the twig
file.
adunsulag added a commit that referenced this issue Sep 18, 2023
* Refactor oauth2 login pages #6845,#6844

Made the login error messages show up - Fixes #6845

Refactored the patient-select,scope-authorize,login pages into twig
files that share a twig base of oauth2-base.html.twig.  Added
PageTemplateRender events that module writers can key into / override if
they need to.

Moved the MFA script into the config.yaml so we can grab it in the twig
file.

* Minor code review fixes

* Fix copyright issues.

* Fix escaping and patient-select
@adunsulag adunsulag added this to the 7.0.2 milestone Nov 16, 2023
@adunsulag adunsulag changed the title bug: Display oauth2 login error messages bug: Display oauth2 login error messages on login authorization page. Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant