The new taxonomy loading system doesn't work for flavors

[teolemon]

The new taxonomy loading system doesn't work for flavors

[teolemon]

introduced by this PR
#2122

[dobriseb]

In fact LoadTaxonomiesService is only used by SplashPresenter.java, and this is after a test in line 37 : if (BuildConfig.FLAVOR.equals("off")) {...
Is there differents list of files to be load in OBF, OFF, OPF and OPFF ?
eg : OFF needs to load labels.json, tags.json, allergens.json, countries.json, additives.json, categories.json and soon ingredients.json.
Does OBF needs the same ?
Does this files all exists on server side for OBF ?
Same questions for OPF and OPPF.

[dobriseb]

Well, for what I've found :
OFF has labels.json, tags.json, allergens.json, countries.json, additives.json, categories.json and ingredients.json
OBF has labels.json, tags.json, countries.json, additives.json, categories.json and ingredients.json (same except allergens.json)
OPF only has tags.json and categories.json
OPFF only has tags.json and categories.json
Can someone confirm this ?

[dobriseb]

Here is my proposition of correction coupled with ingredients.json import.
#2367