Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default name of list for OBF, OPF, OPFF #3066

Closed
Tracked by #4168
teolemon opened this issue Apr 15, 2020 · 5 comments · Fixed by #4616
Closed
Tracked by #4168

Change default name of list for OBF, OPF, OPFF #3066

teolemon opened this issue Apr 15, 2020 · 5 comments · Fixed by #4616
Labels
bug Produces incorrect or unexpected result or behaviour. easy fix Easily fixable issues, good for first timers help wanted lists Open Beauty Facts Issues relating to Open Beauty Facts Open Pet Food Facts Issues relating to Open Pet Food Facts Open Products Facts Issues relating to Open Products Facts

Comments

@teolemon
Copy link
Member

The default name of list is "eaten products". Change that to "Product that I have" for OBF, OPF, OPFF
@teolemon teolemon added bug Produces incorrect or unexpected result or behaviour. easy fix Easily fixable issues, good for first timers Open Beauty Facts Issues relating to Open Beauty Facts Open Pet Food Facts Issues relating to Open Pet Food Facts Open Products Facts Issues relating to Open Products Facts lists labels Apr 15, 2020
@epicadk
Copy link

epicadk commented Sep 28, 2020

Can I work on this?

@VaiTon
Copy link
Member

VaiTon commented Oct 24, 2020

@epicadk sure you can! I'm assigning you! 👍

@epicadk epicadk removed their assignment Oct 24, 2020
@epicadk
Copy link

epicadk commented Oct 24, 2020

un assigning as this issue has already been solved

@VaiTon
Copy link
Member

VaiTon commented Oct 29, 2020

@epicadk what do you mean? How has this been solved?

@yukiisbored
Copy link
Contributor

I just cloned the project (I'm on commit fa6fa46) and can confirm that the default is now "Product that I have". Unless I misunderstood what "Change default name of list" means, I think this issue is fixed.

Screenshot_1606003704

@teolemon teolemon mentioned this issue Aug 22, 2021
Open
15 tasks
VaiTon added a commit to VaiTon/openfoodfacts-androidapp that referenced this issue Mar 27, 2022
@VaiTon
fix: change default name for lists
910f159 
chore: rename getProductListsDaoWithDefaultList to defaultIfEmpty in ProductListsActivity.kt

Closes openfoodfacts#3066
@VaiTon VaiTon mentioned this issue Mar 27, 2022
Merged
VaiTon added a commit that referenced this issue Apr 6, 2022
@VaiTon
fix: change default name for lists (#4616)
7b56644 
chore: rename getProductListsDaoWithDefaultList to defaultIfEmpty in ProductListsActivity.kt

Closes #3066
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Produces incorrect or unexpected result or behaviour. easy fix Easily fixable issues, good for first timers help wanted lists Open Beauty Facts Issues relating to Open Beauty Facts Open Pet Food Facts Issues relating to Open Pet Food Facts Open Products Facts Issues relating to Open Products Facts
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: change default name for lists VaiTon/openfoodfacts-androidapp
4 participants
@teolemon @VaiTon @yukiisbored @epicadk