Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lgwebos] Add semantic tag to Channel and Application channels #18314

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Feb 22, 2025

No description provided.

@jimtng jimtng requested a review from sprehn as a code owner February 22, 2025 12:55
@lolodomo
Copy link
Contributor

Look at #12262

@jimtng
Copy link
Contributor Author

jimtng commented Feb 22, 2025

Look at #12262

Thanks! I've just found it earlier from your response to the forums about semantic model. How would you suggest the Channel and Application channels be tagged in this case? I think it would be handy for them to be included into the Semantic model, so they can show up in the automatic cards alongside power, volume, etc.

@lsiepel
Copy link
Contributor

lsiepel commented Feb 23, 2025

The current list does not have any tag that match channel or application, so they should not be added.

But there are more bindings with similar channsl and to me that justifies some propertiers to be added: https://github.com/openhab/openhab-core/blob/main/bundles/org.openhab.core.semantics/model/SemanticTags.csv

Maybe creating a PR is the best way of moving that forward.

Signed-off-by: Jimmy Tanagra <[email protected]>
@jimtng
Copy link
Contributor Author

jimtng commented Feb 23, 2025

Core PR to add Channel and Application
openhab/openhab-core#4616

@jlaur jlaur added enhancement An enhancement or new feature for an existing add-on awaiting other PR Depends on another PR labels Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting other PR Depends on another PR enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants