-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8349921: Crash in codeBuffer.cpp:1004: guarantee(sect->end() <= tend) failed: sanity #23776
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back adinn! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good.
@vnkozlov Thanks for the review |
@vnkozlov Andrew Leonard has confirmed that the build problem originally encountered on the Adoptium build system is resolved by this patch. |
The compiler blob base size needs increasing in case the JDK is built without ZGC. The increment when ZGC is used can be comparably decreased. The final blob size increment when ZGC is included is over generous and can also be decreased.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23776/head:pull/23776
$ git checkout pull/23776
Update a local copy of the PR:
$ git checkout pull/23776
$ git pull https://git.openjdk.org/jdk.git pull/23776/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 23776
View PR using the GUI difftool:
$ git pr show -t 23776
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23776.diff
Using Webrev
Link to Webrev Comment