Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8349921: Crash in codeBuffer.cpp:1004: guarantee(sect->end() <= tend) failed: sanity #23776

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

adinn
Copy link
Contributor

@adinn adinn commented Feb 25, 2025

The compiler blob base size needs increasing in case the JDK is built without ZGC. The increment when ZGC is used can be comparably decreased. The final blob size increment when ZGC is included is over generous and can also be decreased.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8349921: Crash in codeBuffer.cpp:1004: guarantee(sect->end() <= tend) failed: sanity (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23776/head:pull/23776
$ git checkout pull/23776

Update a local copy of the PR:
$ git checkout pull/23776
$ git pull https://git.openjdk.org/jdk.git pull/23776/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23776

View PR using the GUI difftool:
$ git pr show -t 23776

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23776.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 25, 2025

👋 Welcome back adinn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@adinn adinn changed the title Ensure final and compiler stub sizes correctly allow for ZGC JDK-8349921 Crash in codeBuffer.cpp:1004: guarantee(sect->end() <= tend) failed: sanity Feb 25, 2025
@adinn adinn changed the title JDK-8349921 Crash in codeBuffer.cpp:1004: guarantee(sect->end() <= tend) failed: sanity 8349921 Crash in codeBuffer.cpp:1004: guarantee(sect->end() <= tend) failed: sanity Feb 25, 2025
@openjdk
Copy link

openjdk bot commented Feb 25, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title 8349921 Crash in codeBuffer.cpp:1004: guarantee(sect->end() <= tend) failed: sanity 8349921: Crash in codeBuffer.cpp:1004: guarantee(sect->end() <= tend) failed: sanity Feb 25, 2025
@adinn adinn changed the title 8349921: Crash in codeBuffer.cpp:1004: guarantee(sect->end() <= tend) failed: sanity 8349921: Crash in codeBuffer.cpp:1004: guarantee(sect->end() <= tend) failed: sanity Feb 25, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 25, 2025
@openjdk
Copy link

openjdk bot commented Feb 25, 2025

@adinn The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot changed the title 8349921: Crash in codeBuffer.cpp:1004: guarantee(sect->end() <= tend) failed: sanity 8349921: Crash in codeBuffer.cpp:1004: guarantee(sect->end() <= tend) failed: sanity Feb 25, 2025
@mlbridge
Copy link

mlbridge bot commented Feb 25, 2025

Webrevs

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

@adinn
Copy link
Contributor Author

adinn commented Feb 26, 2025

@vnkozlov Thanks for the review

@adinn
Copy link
Contributor Author

adinn commented Feb 26, 2025

@vnkozlov Andrew Leonard has confirmed that the build problem originally encountered on the Adoptium build system is resolved by this patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler [email protected] rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants