8327478: Add System test to verify TextSelection issue for webkit-617.1 #1719
Conversation
|
Hi @Gopalora, welcome to this OpenJDK project and thanks for contributing! We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user Gopalora" as summary for the issue. If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing |
|
❗ This change is not yet ready to be integrated. |
|
/covered |
|
Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated! |
|
@Gopalora Please enable GHA tests on your repo. I'll provide a few comments now, and formally review it once your OCA status is verified. |
| int y = (int)(scene.getWindow().getY() + scene.getY() + 15); | ||
|
|
||
| Util.runAndWait(() -> { | ||
| robot.mouseMove(1, 1); |
There was a problem hiding this comment.
Minor: use the utility method Util.parkCursor(robot); instead
| Util.sleep(500); | ||
|
|
||
| Util.runAndWait(() -> { | ||
| robot.mouseMove(1, 1); |
There was a problem hiding this comment.
Minor: use the utility method Util.parkCursor(robot); instead
| robot.mousePress(MouseButton.PRIMARY); | ||
| robot.mouseRelease(MouseButton.PRIMARY); | ||
| Util.sleep(50); | ||
| robot.mousePress(MouseButton.PRIMARY); | ||
| robot.mouseRelease(MouseButton.PRIMARY); |
There was a problem hiding this comment.
Minor: You can call robot.mouseClick(MouseButton) instead of separate calls to press/release.
Not so minor: You shouldn't' sleep in the FX app thread. Instead, break this block into two separate lambdas passed into to separate calls to runAndWait with the sleep in between them running in the test thread. Like this:
Util.runAndWait(() -> {
...
robot.mouseClick(MouseButton.PRIMARY);
});
Util.sleep(50);
Util.runAndWait(() -> {
robot.mouseClick(MouseButton.PRIMARY);
});
Suggestion: consider creating a doubleClick utility method in the test Util class.
There was no test included with the fix for JDK-8326989,
Hence we are adding a system test now.
Test is written as
Verification:
The test passes with latest webkit source
Also verified that test fails when the fix for JDK-8326989 is reverted.
Progress
Error
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1719/head:pull/1719$ git checkout pull/1719Update a local copy of the PR:
$ git checkout pull/1719$ git pull https://git.openjdk.org/jfx.git pull/1719/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1719View PR using the GUI difftool:
$ git pr show -t 1719Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1719.diff