8332947: [macos] java.awt.desktop.OpenURIHandler is not receiving events #1720
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to register an open URI handler when using JavaFX with a native menu, this task fails on Mac.
Either the native menu is not shown or the URIs are not received.
This pull request fixes this issue if the registration takes place inside the start method of an application before calling the show method.
The test for this pull request is non trivial, as the application needs to be installed on the Mac before it can be tested. Therefore the test is provided in a separate repository and it needs to be discussed if the test is necessary to have inside the JFX repo and if so, how it should be integrated.
Co-Author: @FlorianKirmaier
Link to the test repo: https://github.com/pabulaner/openurifx
Progress
Error
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1720/head:pull/1720
$ git checkout pull/1720
Update a local copy of the PR:
$ git checkout pull/1720
$ git pull https://git.openjdk.org/jfx.git pull/1720/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1720
View PR using the GUI difftool:
$ git pr show -t 1720
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1720.diff