Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8332947: [macos] java.awt.desktop.OpenURIHandler is not receiving events #1720

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pabulaner
Copy link

@pabulaner pabulaner commented Feb 21, 2025

When trying to register an open URI handler when using JavaFX with a native menu, this task fails on Mac.
Either the native menu is not shown or the URIs are not received.

This pull request fixes this issue if the registration takes place inside the start method of an application before calling the show method.

The test for this pull request is non trivial, as the application needs to be installed on the Mac before it can be tested. Therefore the test is provided in a separate repository and it needs to be discussed if the test is necessary to have inside the JFX repo and if so, how it should be integrated.

Co-Author: @FlorianKirmaier

Link to the test repo: https://github.com/pabulaner/openurifx


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Error

 ⚠️ OCA signatory status must be verified

Issue

  • JDK-8332947: [macos] java.awt.desktop.OpenURIHandler is not receiving events (Bug - P4)(⚠️ The fixVersion in this issue is [25] but the fixVersion in .jcheck/conf is jfx25, a new backport will be created when this pr is integrated.)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1720/head:pull/1720
$ git checkout pull/1720

Update a local copy of the PR:
$ git checkout pull/1720
$ git pull https://git.openjdk.org/jfx.git pull/1720/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1720

View PR using the GUI difftool:
$ git pr show -t 1720

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1720.diff

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Feb 21, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Feb 21, 2025

Hi @pabulaner, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user pabulaner" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented Feb 21, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oca Needs verification of OCA signatory status
Development

Successfully merging this pull request may close these issues.

1 participant