[REVIEW]: xclim: xarray-based climate data analytics #5415
Comments
editorialbot
added
Makefile
pyOpenSci
|
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type: For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type: |
|
|
Wordcount for |
|
|
Here is the pyOpenSci review issue, where this submission was already reviewed: pyOpenSci/software-submission#73 |
|
Paper looks good ✅ @Zeitsperre Do you have a Zenodo archive associated with your pyOpenSci review? |
|
Hi @kthyng Please excuse the late response (I was on vacation). We have a permanent Zenodo DOI, but the last version does not yet include the pyOpenSci-approved build version (we are releasing a new version on 5 May). When released, it should be available automatically and immediately here: https://zenodo.org/record/7796479 |
|
Hi @Zeitsperre! We should associate the DOI associated with the pyOpenSci review with the JOSS paper, so it looks like we need to wait for that? Also we request for JOSS submissions that the metadata for that archive be altered so that the title and author list exactly match the JOSS paper (looks more polished that way) — could you do that for the upcoming release? |
|
@kthyng Sure thing! We'll be releasing a new version this week, either tomorrow or Wednesday. I can make those changes before then. |
|
We've just released a new version of xclim on PyPI (conda-forge later today) and have synchronized the authorship for Zenodo and the paper submission. Let me know if there's anything else that needs doing on my end. Thanks! |
|
Hi @Zeitsperre! Is this the DOI you wanted? 10.5281/zenodo.7916446 and if so can you update so the title match? |
|
And the author list I guess? It is a lot longer on Zenodo than on the paper. |
|
Hi @kthyng, I don't think I have control over the title and information generated by @editorialbot, but yes, we would be submitting v0.43.0. I imagine that for the DOI, you need the static DOI to v0.43.0? In that case, yes, 10.5281/zenodo.7916446 looks good. It's unfortunate, but the Zenodo and paper references were only synchronized in the branch containing the paper (https://github.com/Ouranosinc/xclim/tree/joss_submission). I'm not sure if this is a blocker for the review moving forward. |
|
@Zeitsperre I'm not sure we're talking about the same thing — let me try again. As you said, yes we want to have a specific match from your code as a release to the JOSS paper since of course the code is changing over time but a specific version was reviewed. But for that specific Zenodo release we prefer to have the title in the metadata match your JOSS paper and your author list match the JOSS paper, if possible (not required). I believe you can edit the metadata by hand for a specific version even if normally it is done automatically. So I would be looking for the author list and title to match your JOSS paper for this archive version: https://zenodo.org/record/7916446#.ZGJMNuzMLlw But, if it isn't possible or you don't want to, let me know. And sorry if you are addressing this but I'm just not understanding! |
|
Ah, I think I understand now. We release fairly regularly, so we tend to simply name our releases with the version numbers, but I see now that we can rename v0.43.0 on Zenodo with the title as written in the paper. Thanks for your patience! For the author list, it would be great to have the author order as listed in the paper. I'll see if I can update this list momentarily. |
|
@kthyng Changes have been made to the Zenodo entry. Thanks again for the clairifications! |
|
@Zeitsperre Title looks good! But, the author list doesn't match? I know it is tricky when you have your author list match the JOSS paper? |
|
My bad! I'll double-check. Please excuse my errors! |
|
@kthyng I just checked again, and I think these are in sync. From the paper (affiliations omitted for readability): - name: Pascal Bourgault
- name: David Huard
- name: Trevor James Smith
- name: Travis Logan
- name: Abel Aoun
- name: Juliette Lavoie
- name: Éric Dupuis
- name: Gabriel Rondeau-Genessse
- name: Raquel Alegre
- name: Clair Barnes
- name: Alexis Beaupré Laperrière
- name: Sébastien Biner
- name: David Caron
- name: Carsten Ehbrecht
- name: Jeremy Fyke
- name: Tom Keel
- name: Marie-Pier Labonté
- name: Ludwig Lierhammer
- name: Jwen-Fai Low
- name: Jamie Quinn
- name: Philippe Roy
- name: Dougie Squire
- name: Ag Stephens
- name: Maliko Tanguy
- name: Christopher WhelanOn Zenodo: For each version, we also list the names of the contributors that added code specifically for that release, so this list will be much shorter, i.e.:
Could that be the source of confusion? |
|
@editorialbot generate pdf |
|
@editorialbot set v0.43.0 as version |
|
Done! version is now v0.43.0 |
|
@Zeitsperre Sorry for all the delays, we are ready to finish now! |
|
@editorialbot accept |
|
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
|
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
|
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
|
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
|
@kthyng This is fantastic news! Thanks for much for your help! I can't wait to announce it! I had one author mention late this morning that they'd like their affiliation updated if possible. If it's too late, not a problem. All the best, |
|
Congrats on your new publication @Zeitsperre!! |
|
ok you should be able to update your paper and then we can accept it again. |
|
OK! We are ready (for real this time)! Thanks again! |
|
@editorialbot re-accept |
|
I'm sorry human, I don't understand that. You can see what commands I support by typing:
|
|
@editorialbot reaccept |
|
|
🌈 Paper updated! New PDF and metadata files 👉 openjournals/joss-papers#4246 |
|
@Zeitsperre could you take a look and see if it is fixed? |
|
Yes! Everything looks good! Thanks so much! |
|
Ok great, I'll close this issue now. Congrats again! I'm sharing your package with colleagues since it looks really useful! |
|
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets: This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
### What kind of change does this PR introduce? This PR finalizes the submission and publishing steps for the [Journal of Open Source Software](https://joss.readthedocs.io/en/latest/index.html). The paper is expected to have a length of 250 - 1000 words and demands that the software is *feature-complete*. As such, the submission process should not be started until we have at the very least added all necessary indicators from our backlog and/or stabilized our API (i.e.: v1.0-alpha or release-candidate). Updates (May 2023): With xclim v0.40.0, the software was deemed ready for submission. The review process for JOSS was completed via PyOpenSci (pyOpenSci/software-submission#73), and the final JOSS review was performed in openjournals/joss-reviews#5415. The software (v0.43.0) and paper were published on 18 May 2023 (https://doi.org/10.21105/joss.05415). ### Does this PR introduce a breaking change? No. --------- Co-authored-by: Philippe Roy <[email protected]> Co-authored-by: David Huard <[email protected]> Co-authored-by: Abel Aoun <[email protected]> Co-authored-by: Pascal Bourgault <[email protected]> Co-authored-by: tlogan2000 <[email protected]>
Submitting author: @Zeitsperre (Trevor James Smith)
Repository: https://github.com/Ouranosinc/xclim
Branch with paper.md (empty if default branch): joss_submission
Version: v0.43.0
Editor: @kthyng
Reviewers: @kthyng
Archive: 10.5281/zenodo.7916446
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@kthyng, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @kthyng know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
@kthyng, please create your checklist typing:
@editorialbot generate my checklistThe text was updated successfully, but these errors were encountered: