-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(refactor) Refactor appointments dashboard widget #1476
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR makes the following changes to the appointments dashboard widget: - Changes the extension of the AppointmentsDetailedSummary component to `.extension` to signify that it is an extension. - Adds a `hideDashboardTitle` meta property to the `AppointmentsDetailedSummary` extension to hide the dashboard title, aligning it with the other extensions in the dashboard. - Removes redundant styling from the `PatientAppointmentsBase` component to make it more consistent with the other extensions in the dashboard.
Size Change: -2.94 kB (-0.04%) Total Size: 7.03 MB ℹ️ View Unchanged
|
ibacher
approved these changes
Jan 30, 2025
Samstar10
pushed a commit
to Samstar10/openmrs-esm-patient-management
that referenced
this pull request
Feb 4, 2025
This PR makes the following changes to the appointments dashboard widget: - Changes the extension of the AppointmentsDetailedSummary component to `.extension` to signify that it is an extension. - Adds a `hideDashboardTitle` meta property to the `AppointmentsDetailedSummary` extension to hide the dashboard title, aligning it with the other extensions in the dashboard. - Removes redundant styling from the `PatientAppointmentsBase` component to make it more consistent with the other extensions in the dashboard.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR makes the following changes to the appointments dashboard widget:
.extension
to signify that it is an extension.hideDashboardTitle
meta property to theAppointmentsDetailedSummary
extension to hide the dashboard title, aligning it with the other extensions in the dashboard.PatientAppointmentsBase
component to make it more consistent with the other extensions in the dashboard.Screenshots
Before
After
Related Issue
Other