-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Заголовки не преобразуются в push #1458
Comments
Before nginx/1.13.9 released, the BTW, it's better to use English here. |
Since Nginx/1.13.10. The `Link` header was treated as a common header and equipped a shortcut pointer (`r->headers_out.link`). Currently this module doesn't follow this behavior. Consequently, `Link` header set by this module (e.g. in `header_filter_by_lua*`) cannot be referenced from `r->headers_out.link`. It may cause some inconsistent problems. For instance, the HTTP/2 server push preload, see openresty#1458 for details. This Commit placed the Link header inside `ngx_http_lua_set_handlers[]`.
@Wladimir-N |
This Pull Request was merged just now. Now you can try the master branch and I believe the problem was fixed. |
cc @thibaultcha |
Considering this resolved. Thanks @tokers. |
Включил http2_push_preload on;, если делать заголовок с nginx или php-fpm всё проходит корректно. Но если я делаю заголовки с lua из header_filter_by_lua_block {} при помощи ngx.header.link то заголовки есть, а push-запросов нет.
uname -a
Linux web 4.4.138-qs #2 SMP Mon Oct 15 13:09:10 MSK 2018 x86_64 GNU/Linux
nginx -V
nginx version: nginx/1.14.1 built with OpenSSL 1.1.0f 25 May 2017 (running with OpenSSL 1.1.0j 20 Nov 2018) TLS SNI support enabled configure arguments: --with-cc-opt='-g -O2 -fdebug-prefix-map=/build/nginx-jqo7Nx/nginx-1.14.1=. -fstack-protector-strong -Wformat -Werror=format-security -fPIC -Wdate-time -D_FORTIFY_SOURCE=2' --with-ld-opt='-Wl,-z,relro -Wl,-z,now -fPIC' --prefix=/usr/share/nginx --conf-path=/etc/nginx/nginx.conf --http-log-path=/var/log/nginx/access.log --error-log-path=/var/log/nginx/error.log --lock-path=/var/lock/nginx.lock --pid-path=/run/nginx.pid --modules-path=/usr/lib/nginx/modules --http-client-body-temp-path=/var/lib/nginx/body --http-fastcgi-temp-path=/var/lib/nginx/fastcgi --http-proxy-temp-path=/var/lib/nginx/proxy --http-scgi-temp-path=/var/lib/nginx/scgi --http-uwsgi-temp-path=/var/lib/nginx/uwsgi --with-debug --with-pcre-jit --with-http_ssl_module --with-http_stub_status_module --with-http_realip_module --with-http_auth_request_module --with-http_v2_module --with-http_dav_module --with-http_slice_module --with-threads --with-http_addition_module --with-http_geoip_module=dynamic --with-http_gunzip_module --with-http_gzip_static_module --with-http_image_filter_module=dynamic --with-http_sub_module --with-http_xslt_module=dynamic --with-stream=dynamic --with-stream_ssl_module --with-stream_ssl_preread_module --with-mail=dynamic --with-mail_ssl_module --add-dynamic-module=/build/nginx-jqo7Nx/nginx-1.14.1/debian/modules/http-auth-pam --add-dynamic-module=/build/nginx-jqo7Nx/nginx-1.14.1/debian/modules/http-dav-ext --add-dynamic-module=/build/nginx-jqo7Nx/nginx-1.14.1/debian/modules/http-echo --add-dynamic-module=/build/nginx-jqo7Nx/nginx-1.14.1/debian/modules/http-upstream-fair --add-dynamic-module=/build/nginx-jqo7Nx/nginx-1.14.1/debian/modules/http-subs-filter
The text was updated successfully, but these errors were encountered: