Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record a SourcesFileResults.Row for generated sources #5064

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

timtebeek
Copy link
Contributor

What's your motivation?

Anything in particular you'd like reviewers to focus on?

Do we want to see additional effort logged for #4909 ? This seemed like an omission, but I'm not sure about further changes.

Anyone you would like to review specifically?

@bmuschko @sambsnyd

Have you considered any alternatives or workarounds?

We could also assign some effort for the scanning phase of a recipe, or when creating a data table row. That seems a bit further removed from how we've traditionally estimated and measured effort though, so not (yet) included here.

@timtebeek
Copy link
Contributor Author

Draft as I hadn't ran the tests yet, but otherwise ok to merge if you ask me. I'll look at this again with fresh eyes tomorrow.

@timtebeek timtebeek marked this pull request as ready for review February 19, 2025 10:09
@timtebeek timtebeek merged commit 9c6fa98 into main Feb 19, 2025
2 checks passed
@timtebeek timtebeek deleted the record-source-file-results-for-generated-sources branch February 19, 2025 10:27
@bmuschko
Copy link
Contributor

I think it would make sense to override getEstimatedEffortPerOccurrence() in ScanningRecipe and return a value of Duration.ofMinutes(0). Now, that we calculate time savings for ScanningRecipe, "finder" recipes would provide a time saving which probably shouldn't be accounted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants