[workspace]remove * when calling find in data source association modal and in workspace list page

[Qxisylolo]

Description

This pr remove * when calling find in data source association modal and in workspace list page

Issues Resolved

Screenshot

Inside a workspace, and we want to find all the data sources which belong to the current workspaces, here we remove the client base path

Inside a workspace and open data source association modal, we want to find all the data sources, here we remove the client base path

in workspace list page, we also remove the client base path

Testing the changes

Changelog

• fix: remove * when calling find in data source association modal and in workspace list page

Check List

• All tests pass
  • yarn test:jest
  • yarn test:jest_integration
• New functionality includes testing.
• New functionality has been documented.
• Update CHANGELOG.md
• Commits are signed per the DCO using --signoff

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.71%. Comparing base (6cf56f0) to head (e40df3a).
Report is 9 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #9409   +/-   ##
=======================================
  Coverage   61.71%   61.71%           
=======================================
  Files        3817     3817           
  Lines       91862    91862           
  Branches    14552    14552           
=======================================
  Hits        56697    56697           
  Misses      31509    31509           
  Partials     3656     3656           

Flag	Coverage Δ
Linux_1	29.00% <75.00%> (ø)
Linux_2	56.46% <100.00%> (ø)
Linux_3	39.20% <0.00%> (-0.01%)	⬇️
Linux_4	28.90% <0.00%> (ø)
Windows_1	29.01% <75.00%> (ø)
Windows_2	56.41% <100.00%> (ø)
Windows_3	39.20% <0.00%> (-0.01%)	⬇️
Windows_4	28.90% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[wanglam]

We still pass '' to getDataSourcesList in line 367 of this file. Can we remove the '' argument?

[Qxisylolo]

okok, I miss it, thanks for noticing

[SuZhou-Joe]

Actually not very comfortable with this line. I am thinking if we can pass prependOptions directly instead of detecting whether there is workspaces inside query.

[Qxisylolo]

my initial thought is to directly pass prependOptions and already tested it, it worked well when calling inside a workspace, but I'm not sure then. already update~

[wanglam]

@Qxisylolo Is it safe to remove the * filtering logic in workspace id consumer wrapper? It was added to get all data sources. But it seems we don't pass * now.

[Qxisylolo]

@Qxisylolo Is it safe to remove the '' filtering logic in workspace id consumer wrapper? It was added to get all data sources. But it seems we don't pass '' now.

we don't use this function to filter * now. perhaps we could remove it in find

[SuZhou-Joe]

Actually I am thinking:

savedObjectsClient.find({ ...otherParams, workspaces: null }, { prependOptions: { withoutClientBasePath: true } })

We should let client to decide how to make the call instead of removing the clientBasePath in the find method directly. It is a service used by many modules.

[wanglam]

@Qxisylolo DCO failed for the latest commit, could you help to fix it?