backort PR#15602

Signed-off-by: Anshu Agarwal <[email protected]>
opensearch-project · Sep 3, 2024 · a5679b2 · a5679b2
1 parent 282e451
commit a5679b2
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 1 deletion.
diff --git a/server/src/main/java/org/opensearch/snapshots/SnapshotsService.java b/server/src/main/java/org/opensearch/snapshots/SnapshotsService.java
@@ -225,7 +225,7 @@ public class SnapshotsService extends AbstractLifecycleComponent implements Clus
         Setting.Property.Dynamic
     );
 
-    private static final String SNAPSHOT_PINNED_TIMESTAMP_DELIMITER = ":";
+    private static final String SNAPSHOT_PINNED_TIMESTAMP_DELIMITER = "__";
     private volatile int maxConcurrentOperations;
 
     public SnapshotsService(

diff --git a/server/src/test/java/org/opensearch/repositories/RepositoriesServiceTests.java b/server/src/test/java/org/opensearch/repositories/RepositoriesServiceTests.java
@@ -667,6 +667,19 @@ public void initializeSnapshot(SnapshotId snapshotId, List<IndexId> indices, Met
 
         }
 
+        @Override
+        public void finalizeSnapshot(
+            ShardGenerations shardGenerations,
+            long repositoryStateId,
+            Metadata clusterMetadata,
+            SnapshotInfo snapshotInfo,
+            Version repositoryMetaVersion,
+            Function<ClusterState, ClusterState> stateTransformer,
+            ActionListener<RepositoryData> listener
+        ) {
+            listener.onResponse(null);
+        }
+
         @Override
         public void finalizeSnapshot(
             ShardGenerations shardGenerations,

diff --git a/test/framework/src/main/java/org/opensearch/index/shard/RestoreOnlyRepository.java b/test/framework/src/main/java/org/opensearch/index/shard/RestoreOnlyRepository.java
@@ -122,6 +122,19 @@ public void getRepositoryData(ActionListener<RepositoryData> listener) {
     @Override
     public void initializeSnapshot(SnapshotId snapshotId, List<IndexId> indices, Metadata metadata) {}
 
+    @Override
+    public void finalizeSnapshot(
+        ShardGenerations shardGenerations,
+        long repositoryStateId,
+        Metadata clusterMetadata,
+        SnapshotInfo snapshotInfo,
+        Version repositoryMetaVersion,
+        Function<ClusterState, ClusterState> stateTransformer,
+        ActionListener<RepositoryData> listener
+    ) {
+        listener.onResponse(null);
+    }
+
     @Override
     public void finalizeSnapshot(
         ShardGenerations shardGenerations,