Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] SegRep with Remote: Add hook for publishing checkpoint notifications after segment upload to remote store (#7394) #7718

Merged
merged 1 commit into from
May 24, 2023

Conversation

ashking94
Copy link
Member

@ashking94 ashking94 commented May 24, 2023

  • SegRep with Remote: Add hook for publishing checkpoint notifications after segment upload to remote store

  • Added changelog

  • Fix the test

  • gradle check

  • Addressed PR comments

  • Addressing PR comments 2

  • Addressed comments 3

  • Fix Changelog entry


Description

This backports #7394

Related Issues

Resolves #5578

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…after segment upload to remote store (opensearch-project#7394)

* SegRep with Remote: Add hook for publishing checkpoint notifications after segment upload to remote store

Signed-off-by: Ankit Kala <[email protected]>

* Added changelog

Signed-off-by: Ankit Kala <[email protected]>

* Fix the test

Signed-off-by: Ankit Kala <[email protected]>

* gradle check

Signed-off-by: Ankit Kala <[email protected]>

* Addressed PR comments

Signed-off-by: Ankit Kala <[email protected]>

* Addressing PR comments 2

Signed-off-by: Ankit Kala <[email protected]>

* Addressed comments 3

Signed-off-by: Ankit Kala <[email protected]>

* Fix Changelog entry

Signed-off-by: Ankit Kala <[email protected]>

---------

Signed-off-by: Ankit Kala <[email protected]>
Signed-off-by: Ashish Singh <[email protected]>
@ashking94 ashking94 changed the title SegRep with Remote: Add hook for publishing checkpoint notifications … [Backport 2.x] SegRep with Remote: Add hook for publishing checkpoint notifications after segment upload to remote store (#7394) May 24, 2023
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.search.SearchWeightedRoutingIT.testStrictWeightedRoutingWithCustomString

@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #7718 (61ab7b2) into 2.x (636e772) will increase coverage by 0.07%.
The diff coverage is 71.42%.

@@             Coverage Diff              @@
##                2.x    #7718      +/-   ##
============================================
+ Coverage     70.53%   70.60%   +0.07%     
- Complexity    56370    56408      +38     
============================================
  Files          4663     4663              
  Lines        267521   267530       +9     
  Branches      39612    39616       +4     
============================================
+ Hits         188701   188897     +196     
+ Misses        62604    62332     -272     
- Partials      16216    16301      +85     
Impacted Files Coverage Δ
.../main/java/org/opensearch/index/IndexSettings.java 85.35% <0.00%> (-0.44%) ⬇️
...in/java/org/opensearch/index/shard/IndexShard.java 70.35% <66.66%> (+0.13%) ⬆️
...nsearch/index/shard/CheckpointRefreshListener.java 91.66% <75.00%> (-8.34%) ⬇️
...search/index/shard/RemoteStoreRefreshListener.java 81.56% <100.00%> (-0.33%) ⬇️

... and 460 files with indirect coverage changes

@gbbafna gbbafna merged commit 92571b7 into opensearch-project:2.x May 24, 2023
ankitkala added a commit to ankitkala/OpenSearch that referenced this pull request May 31, 2023
…cations after segment upload to remote store (opensearch-project#7394) (opensearch-project#7718)"

This reverts commit 92571b7.

Signed-off-by: Ankit Kala <[email protected]>
ankitkala added a commit to ankitkala/OpenSearch that referenced this pull request May 31, 2023
…cations after segment upload to remote store (opensearch-project#7394) (opensearch-project#7718)"

This reverts commit 92571b7.

Signed-off-by: Ankit Kala <[email protected]>
ankitkala added a commit to ankitkala/OpenSearch that referenced this pull request May 31, 2023
…cations after segment upload to remote store (opensearch-project#7394) (opensearch-project#7718)"

This reverts commit 92571b7.

Signed-off-by: Ankit Kala <[email protected]>
dreamer-89 pushed a commit that referenced this pull request May 31, 2023
…cations after segment upload to remote store (#7394) (#7718)" (#7839)

This reverts commit 92571b7.

Signed-off-by: Ankit Kala <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants