-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] SegRep with Remote: Add hook for publishing checkpoint notifications after segment upload to remote store (#7394) #7718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…after segment upload to remote store (opensearch-project#7394) * SegRep with Remote: Add hook for publishing checkpoint notifications after segment upload to remote store Signed-off-by: Ankit Kala <[email protected]> * Added changelog Signed-off-by: Ankit Kala <[email protected]> * Fix the test Signed-off-by: Ankit Kala <[email protected]> * gradle check Signed-off-by: Ankit Kala <[email protected]> * Addressed PR comments Signed-off-by: Ankit Kala <[email protected]> * Addressing PR comments 2 Signed-off-by: Ankit Kala <[email protected]> * Addressed comments 3 Signed-off-by: Ankit Kala <[email protected]> * Fix Changelog entry Signed-off-by: Ankit Kala <[email protected]> --------- Signed-off-by: Ankit Kala <[email protected]> Signed-off-by: Ashish Singh <[email protected]>
ankitkala
approved these changes
May 24, 2023
gbbafna
approved these changes
May 24, 2023
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## 2.x #7718 +/- ##
============================================
+ Coverage 70.53% 70.60% +0.07%
- Complexity 56370 56408 +38
============================================
Files 4663 4663
Lines 267521 267530 +9
Branches 39612 39616 +4
============================================
+ Hits 188701 188897 +196
+ Misses 62604 62332 -272
- Partials 16216 16301 +85
|
ankitkala
added a commit
to ankitkala/OpenSearch
that referenced
this pull request
May 31, 2023
…cations after segment upload to remote store (opensearch-project#7394) (opensearch-project#7718)" This reverts commit 92571b7. Signed-off-by: Ankit Kala <[email protected]>
ankitkala
added a commit
to ankitkala/OpenSearch
that referenced
this pull request
May 31, 2023
…cations after segment upload to remote store (opensearch-project#7394) (opensearch-project#7718)" This reverts commit 92571b7. Signed-off-by: Ankit Kala <[email protected]>
6 tasks
ankitkala
added a commit
to ankitkala/OpenSearch
that referenced
this pull request
May 31, 2023
…cations after segment upload to remote store (opensearch-project#7394) (opensearch-project#7718)" This reverts commit 92571b7. Signed-off-by: Ankit Kala <[email protected]>
dreamer-89
pushed a commit
that referenced
this pull request
May 31, 2023
…cations after segment upload to remote store (#7394) (#7718)" (#7839) This reverts commit 92571b7. Signed-off-by: Ankit Kala <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SegRep with Remote: Add hook for publishing checkpoint notifications after segment upload to remote store
Added changelog
Fix the test
gradle check
Addressed PR comments
Addressing PR comments 2
Addressed comments 3
Fix Changelog entry
Description
This backports #7394
Related Issues
Resolves #5578
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.