-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport] [2.x] Enabling Compression Level Index Settings for ZSTD and ZSTD Codecs #8558
Merged
reta
merged 2 commits into
opensearch-project:2.x
from
sarthakaggarwal97:backport/backport-8312-to-2.x
Jul 10, 2023
Merged
[Backport] [2.x] Enabling Compression Level Index Settings for ZSTD and ZSTD Codecs #8558
reta
merged 2 commits into
opensearch-project:2.x
from
sarthakaggarwal97:backport/backport-8312-to-2.x
Jul 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0b15bf2
to
5559781
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
5559781
to
2c8486f
Compare
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## 2.x #8558 +/- ##
============================================
+ Coverage 70.59% 70.68% +0.09%
- Complexity 57082 57105 +23
============================================
Files 4744 4744
Lines 270579 270606 +27
Branches 39939 39943 +4
============================================
+ Hits 191003 191286 +283
+ Misses 63139 62894 -245
+ Partials 16437 16426 -11
|
2c8486f
to
9cf569b
Compare
Gradle Check (Jenkins) Run Completed with:
|
9cf569b
to
dbbc877
Compare
Gradle Check (Jenkins) Run Completed with:
|
reta
reviewed
Jul 9, 2023
server/src/main/java/org/opensearch/index/codec/CodecService.java
Outdated
Show resolved
Hide resolved
dbbc877
to
616419f
Compare
Gradle Check (Jenkins) Run Completed with:
|
616419f
to
cf3e913
Compare
…ject#8312) * Enabling compression levels as index settings Signed-off-by: Sarthak Aggarwal <[email protected]> * addressing review comments Signed-off-by: Sarthak Aggarwal <[email protected]> * refactoring codec service Signed-off-by: Sarthak Aggarwal <[email protected]> * index settings assertion Signed-off-by: Sarthak Aggarwal <[email protected]> * default compression level change in the settings Signed-off-by: Sarthak Aggarwal <[email protected]> --------- Signed-off-by: Sarthak Aggarwal <[email protected]> (cherry picked from commit ca7045e)
cf3e913
to
d829bda
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
mgodwan
approved these changes
Jul 10, 2023
reta
reviewed
Jul 10, 2023
d829bda
to
6ff8abf
Compare
reta
approved these changes
Jul 10, 2023
Gradle Check (Jenkins) Run Completed with:
|
6ff8abf
to
eb87477
Compare
Gradle Check (Jenkins) Run Completed with:
|
eb87477
to
c573940
Compare
Gradle Check (Jenkins) Run Completed with:
|
c573940
to
b7ae674
Compare
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Sarthak Aggarwal <[email protected]>
b7ae674
to
4bb4c09
Compare
Gradle Check (Jenkins) Run Completed with:
|
There are flaky tests out of this pull request: #8593, @sarthakaggarwal97 please take a look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport #8312
Related Issues
Resolves #7555
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.