-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Amend tests to include all codecs #8907
Amend tests to include all codecs #8907
Conversation
Gradle Check (Jenkins) Run Completed with:
|
d47d03f
to
069cff3
Compare
Gradle Check (Jenkins) Run Completed with:
|
069cff3
to
6b63eed
Compare
test/framework/src/main/java/org/opensearch/test/OpenSearchIntegTestCase.java
Outdated
Show resolved
Hide resolved
Gradle Check (Jenkins) Run Completed with:
|
6b63eed
to
62d8a70
Compare
Gradle Check (Jenkins) Run Completed with:
|
62d8a70
to
00b8568
Compare
Gradle Check (Jenkins) Run Completed with:
|
test/framework/src/main/java/org/opensearch/test/OpenSearchIntegTestCase.java
Outdated
Show resolved
Hide resolved
00b8568
to
3ff23cb
Compare
Gradle Check (Jenkins) Run Completed with:
|
There are 3 simultaneous PRs around the new codec introductions that I see: #8737, #8745 and this one (#8907). Is there a meta issue detailing why these changes are being made? I think they should all be linked to a meta to let reviewers see the larger context and the order in which these PRs should be reviewed and merged in. |
3ff23cb
to
5fd40cb
Compare
@Poojita-Raj these three PR's are majorly for refactoring few things related to compression codecs and their settings. All of which are independent of each other. I don't think a meta issue was required for such refactors. |
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Sarthak Aggarwal <[email protected]>
5fd40cb
to
600e0c2
Compare
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #8907 +/- ##
============================================
- Coverage 71.12% 70.99% -0.13%
+ Complexity 57212 57204 -8
============================================
Files 4759 4759
Lines 269881 269881
Branches 39488 39488
============================================
- Hits 191943 191606 -337
- Misses 61752 62133 +381
+ Partials 16186 16142 -44 |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-8907-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c43743dd8ac132314dfe375f712c37a7a0f7d8df
# Push it to GitHub
git push --set-upstream origin backport/backport-8907-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x Then, create a pull request where the |
Signed-off-by: Sarthak Aggarwal <[email protected]> (cherry picked from commit c43743d)
Signed-off-by: Sarthak Aggarwal <[email protected]> (cherry picked from commit c43743d)
This reverts commit c43743d.
This reverts commit c43743d. Signed-off-by: Andriy Redko <[email protected]>
This reverts commit c43743d. Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: Sarthak Aggarwal <[email protected]>
…" (opensearch-project#8968) This reverts commit c43743d. Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: Sarthak Aggarwal <[email protected]>
…" (opensearch-project#8968) This reverts commit c43743d. Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: Sarthak Aggarwal <[email protected]>
…" (opensearch-project#8968) This reverts commit c43743d. Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: Sarthak Aggarwal <[email protected]>
…" (opensearch-project#8968) This reverts commit c43743d. Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: Sarthak Aggarwal <[email protected]>
…" (opensearch-project#8968) This reverts commit c43743d. Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: Sarthak Aggarwal <[email protected]> (cherry picked from commit c43743d)
Signed-off-by: Sarthak Aggarwal <[email protected]>
Signed-off-by: Sarthak Aggarwal <[email protected]>
Signed-off-by: Sarthak Aggarwal <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]>
…" (opensearch-project#8968) This reverts commit c43743d. Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]>
Signed-off-by: Sarthak Aggarwal <[email protected]> Signed-off-by: Ivan Brusic <[email protected]>
…" (opensearch-project#8968) This reverts commit c43743d. Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Ivan Brusic <[email protected]>
Signed-off-by: Sarthak Aggarwal <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
…" (opensearch-project#8968) This reverts commit c43743d. Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
Adds additional codecs to the tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.