Refactored Dashboard::getMonitors to function without using the from and size parameters from getAlerts #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and size parameters from getAlerts (opensearch-project#53) * Refactored MonitorType such that the AD definition option cannot be selected for aggregation monitors. Also implemented logic to clear the form when changing from an unsupported definition option to aggregation monitor type. Reimplemented the query response display in the trigger panel when defining an AD trigger condition using the query response option. Also made minor edits to various other classes to align UX with mocks. * Refactored actions panel to align with new mocks. Disabled throttling when per execution is selected in the action configuration. * Refactored the visual editor for bucket-level triggers to align with new mocks. * Refactored the visual and response editor options for query-level AD triggers to align with new mocks. Refactored form reset logic to remove trigger definitions from the form when changing the monitor type. * Implemented logic to set bucket-level monitor search type to a default value when changing from a query-level monitor with an unsupported search type. * Refactored monitor details panel on the monitor creation/edit page to align with mocks. * Implemented flyout side panel for the alerts dashboard. * Refactored the popover used by query-level visual trigger editor to dropdown menus. Refactored actions panel to hide throttling options when per execution is selected. Set a default throttling value for bucket-level actions. Refactored margins and padding in various classes to align with mocks * Refactored query trigger definition components so code editor box sizes align with mocks. Add a prompt to select a detector for anomaly detection monitors when. * Refactored the alert dashboard flyout to remove the close button in the top-right corner. Moved the detector link on the monitor details page for anomaly detection monitors from under the monitor name to the overview table. * Fixed a bug that was causing the alerts dashboard flyout to display a severity 1 level higher than the actual level. Moved the log statement to the default case of getOverviewStats::getMonitorLevelType. Implemented a toast indicating when a test message is sent to a destination. * Refactored Dashboard::getMonitors to function without using the from and size parameters from getAlerts. Signed-off-by: Annie Lee <[email protected]>
qreshi
approved these changes
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Annie Lee [email protected]
Signed off by Thomas Hurney [email protected]
Description
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.