Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI notification for failed test of alert and destinations #100

Closed
adityaj1107 opened this issue Jun 2, 2021 · 2 comments
Closed

UI notification for failed test of alert and destinations #100

adityaj1107 opened this issue Jun 2, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@adityaj1107
Copy link
Contributor

Issue by renegaderyu
Wednesday May 19, 2021 at 17:16 GMT
Originally opened as opendistro-for-elasticsearch/alerting#378


Is your feature request related to a problem? Please describe.
There is no indication from the UI that a test notification has failed to send to the destination.
It is not possible to test a destination w/o trying to configure an alert.

Describe the solution you'd like
A pop-up alert for failures to test the alert.
Ability to test destinations separately from alerts

@adityaj1107 adityaj1107 added the enhancement New feature or request label Jun 2, 2021
@adityaj1107
Copy link
Contributor Author

adityaj1107 commented Jun 30, 2021

By design we don't throw an exception whenever we are not able to send an alert. We mark that alert in the error state and send that error as a part of the response of the monitor execution result. Since the monitor execution succeeds the response doesn't throw any error and in the frontend code we check for the response status of the request and not the status of the action (which is present in the response content). This results in the front end not showing an error for the action which was not executed.

This implementation is correct from the backend as the monitor execution succeeded and the action is marked in the error state. The problem lies in the front-end response parsing where we should check explicitly for the action response.

@qreshi
Copy link
Contributor

qreshi commented Nov 17, 2021

Closing this issue since the fix was merged on Alerting Dashboards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants