Show Error Toast Message whenever action execution fails from backend due to incorrect configurations #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annie3431
previously approved these changes
Jul 1, 2021
added 3 commits
July 1, 2021 21:48
…Backend to Frontend Signed-off-by: Aditya Jindal <[email protected]>
Signed-off-by: Aditya Jindal <[email protected]>
Signed-off-by: Aditya Jindal <[email protected]>
lezzago
reviewed
Jul 9, 2021
public/pages/CreateTrigger/containers/ConfigureActions/ConfigureActions.js
Show resolved
Hide resolved
annie3431
approved these changes
Jul 9, 2021
lezzago
approved these changes
Jul 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By design we don't throw an exception whenever we are not able to send an alert. We mark that alert in the error state and send that error as a part of the response of the monitor execution result. Since the monitor execution succeeds the response doesn't throw any error and in the frontend code we check for the response status of the request and not the status of the action (which is present in the response content). This results in the front end not showing an error for the action which was not executed.
This implementation is correct from the backend as the monitor execution succeeded and the action is marked in the error state. The problem lies in the front-end response parsing where we should check explicitly for the action response.
This PR addresses that and parses the response to specifically check
Issues Resolved
opensearch-project/alerting#100
Check List
Tested by providing an incorrectly configured Web-hook URL. The
Send Test Messagebutton shows an error toast message.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.