-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding fix for test knn index replication integ test failure #1498
Conversation
Signed-off-by: Mohit Kumar <[email protected]>
Signed-off-by: Mohit Kumar <[email protected]>
Signed-off-by: Mohit Kumar <[email protected]>
* Adding fix for test knn index replication integ test failure Signed-off-by: Mohit Kumar <[email protected]> * Added knn settings for the index Signed-off-by: Mohit Kumar <[email protected]> * Added import statements for settings Signed-off-by: Mohit Kumar <[email protected]> --------- Signed-off-by: Mohit Kumar <[email protected]> Co-authored-by: Mohit Kumar <[email protected]> (cherry picked from commit 21d7929)
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1498-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 21d79296f72b3384da2a9a7147363d24453f24df
# Push it to GitHub
git push --set-upstream origin backport/backport-1498-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.19 2.19
# Navigate to the new working tree
cd .worktrees/backport-2.19
# Create a new branch
git switch --create backport/backport-1498-to-2.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 21d79296f72b3384da2a9a7147363d24453f24df
# Push it to GitHub
git push --set-upstream origin backport/backport-1498-to-2.19
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.19 Then, create a pull request where the |
Hi @mohit10011999 just want to mention seems the same error happens in main: Thanks. |
Description
Description
Added index level setting for specifying knn index
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.