[OpenSearch Playground] Adds matrix for functional test template #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tao liu <[email protected]>
1 task
kavilla
reviewed
Jul 13, 2022
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| run: ['OSD-Functional-Test-AD', 'OSD-Functional-Test-Alert', 'OSD-Functional-Test-Notifications', 'OSD-Functional-Test-Reports', 'OSD-Functional-Test-Observability', 'OSD-Functional-Test-IndexMan'] |
There was a problem hiding this comment.
if you wanted you could do something like this: https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/.github/workflows/build_and_test_workflow.yml#L126
and then it's just like a template where it echos the name and it has the spec
There was a problem hiding this comment.
Thanks. I tried it, but it seems like that include will run first than shared steps, which can be used for build something, our pipeline will run something after shared steps, probably it cannot fit here.
kavilla
approved these changes
Jul 13, 2022
ZilongX
approved these changes
Jul 13, 2022
seraphjiang
approved these changes
Jul 13, 2022
huyaboo
pushed a commit
to huyaboo/dashboards-anywhere
that referenced
this pull request
Jul 19, 2022
Signed-off-by: Tao liu <[email protected]>
huyaboo
pushed a commit
to huyaboo/dashboards-anywhere
that referenced
this pull request
Jul 19, 2022
Signed-off-by: Tao liu <[email protected]> Signed-off-by: Huy Nguyen <[email protected]>
huyaboo
added a commit
that referenced
this pull request
Aug 8, 2022
* First draft of ingestion utility tool Signed-off-by: Huy Nguyen <[email protected]> * Updates workflows to use the reusable workflow (#45) * Updates workflows Signed-off-by: Tao liu <[email protected]> * adds some comments Signed-off-by: Tao liu <[email protected]> * add readme file Signed-off-by: Tao liu <[email protected]> Signed-off-by: Huy Nguyen <[email protected]> * Removed potentially confidential files Signed-off-by: Huy Nguyen <[email protected]> * Fixed unit test so that it will work without an updated certificate Signed-off-by: Huy Nguyen <[email protected]> * adds matrix for functional test template (#49) Signed-off-by: Tao liu <[email protected]> Signed-off-by: Huy Nguyen <[email protected]> * Minor refactoring done to sample_data_ingestor.py Signed-off-by: Huy Nguyen <[email protected]> * Removed files from another branch Signed-off-by: Huy Nguyen <[email protected]> * Reverted changes to .github/workflows Signed-off-by: Huy Nguyen <[email protected]> * Add spaces to os-osd-deployment.yml Signed-off-by: Huy Nguyen <[email protected]> * Removed tab to os-osd-deployment.yml Signed-off-by: Huy Nguyen <[email protected]> * Refactored, decoupled functions, and added size considerations to the BULK call Signed-off-by: Huy Nguyen <[email protected]> * Addressed all comments from second code reviewer Signed-off-by: Huy Nguyen <[email protected]> * Added DataTrend class to ingestion tool Signed-off-by: Huy Nguyen <[email protected]> * Added README.md and USAGE.md; Also added AverageTrend support for floats Signed-off-by: Huy Nguyen <[email protected]> * Added README.md specifically for using the DataTrend interface Signed-off-by: Huy Nguyen <[email protected]> * Removed all whitespace, switched json data files to ndjson, and modified ingestor files Signed-off-by: Huy Nguyen <[email protected]> * Added license headers to all files Signed-off-by: Huy Nguyen <[email protected]> * Addressed all comments from final reviewer Signed-off-by: Huy Nguyen <[email protected]> * Added license headers to all py files, and added newlines to all py files Signed-off-by: Huy Nguyen <[email protected]> * Added minor refactoring details and specified test files Signed-off-by: Huy Nguyen <[email protected]> * Modified sys.path to be more readable Signed-off-by: Huy Nguyen <[email protected]> Co-authored-by: Tao Liu <[email protected]>
seraphjiang
pushed a commit
to seraphjiang/dashboards-anywhere
that referenced
this pull request
Oct 22, 2022
Signed-off-by: Tao liu <[email protected]>
seraphjiang
pushed a commit
to seraphjiang/dashboards-anywhere
that referenced
this pull request
Oct 22, 2022
* First draft of ingestion utility tool Signed-off-by: Huy Nguyen <[email protected]> * Updates workflows to use the reusable workflow (opensearch-project#45) * Updates workflows Signed-off-by: Tao liu <[email protected]> * adds some comments Signed-off-by: Tao liu <[email protected]> * add readme file Signed-off-by: Tao liu <[email protected]> Signed-off-by: Huy Nguyen <[email protected]> * Removed potentially confidential files Signed-off-by: Huy Nguyen <[email protected]> * Fixed unit test so that it will work without an updated certificate Signed-off-by: Huy Nguyen <[email protected]> * adds matrix for functional test template (opensearch-project#49) Signed-off-by: Tao liu <[email protected]> Signed-off-by: Huy Nguyen <[email protected]> * Minor refactoring done to sample_data_ingestor.py Signed-off-by: Huy Nguyen <[email protected]> * Removed files from another branch Signed-off-by: Huy Nguyen <[email protected]> * Reverted changes to .github/workflows Signed-off-by: Huy Nguyen <[email protected]> * Add spaces to os-osd-deployment.yml Signed-off-by: Huy Nguyen <[email protected]> * Removed tab to os-osd-deployment.yml Signed-off-by: Huy Nguyen <[email protected]> * Refactored, decoupled functions, and added size considerations to the BULK call Signed-off-by: Huy Nguyen <[email protected]> * Addressed all comments from second code reviewer Signed-off-by: Huy Nguyen <[email protected]> * Added DataTrend class to ingestion tool Signed-off-by: Huy Nguyen <[email protected]> * Added README.md and USAGE.md; Also added AverageTrend support for floats Signed-off-by: Huy Nguyen <[email protected]> * Added README.md specifically for using the DataTrend interface Signed-off-by: Huy Nguyen <[email protected]> * Removed all whitespace, switched json data files to ndjson, and modified ingestor files Signed-off-by: Huy Nguyen <[email protected]> * Added license headers to all files Signed-off-by: Huy Nguyen <[email protected]> * Addressed all comments from final reviewer Signed-off-by: Huy Nguyen <[email protected]> * Added license headers to all py files, and added newlines to all py files Signed-off-by: Huy Nguyen <[email protected]> * Added minor refactoring details and specified test files Signed-off-by: Huy Nguyen <[email protected]> * Modified sys.path to be more readable Signed-off-by: Huy Nguyen <[email protected]> Co-authored-by: Tao Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tao liu [email protected]
Description
The current GitHub action functional test template didn't use matrix. In order to make template more maintainable, adds matrix to functional test template.
Reference: GitHub action matrix
Issues Resolved
Resolve #48
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.