Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Prepper Expression add concurrency support #1189

Closed
sbayer55 opened this issue Mar 14, 2022 · 0 comments · Fixed by #1840
Closed

Data Prepper Expression add concurrency support #1189

sbayer55 opened this issue Mar 14, 2022 · 0 comments · Fixed by #1840
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@sbayer55
Copy link
Member

Is your feature request related to a problem? Please describe.
Today DropEventsProcessor requires the annotation @SingleThread and ConditionalExpressionEvaluator requires @Scope(ConfigurableBeanFactory.SCOPE_PROTOTYPE).

DropEventsProcessor could be a shared instance processor if ConditionalExpressionEvaluator had support for concurrent execution.

Describe the solution you'd like
Enhance ConditionalExpressionEvaluator to support concurrent execution.

A few options that could work:

  1. Modify ConditionalExpressionEvaluator.evaluate(...) to return a future that contains a scoped instance of ParseTreeEvaluatorListener
  2. Add a synchronous queue of requests to ConditionalExpressionEvaluator
  3. Create a ParseTreeEvaluatorListener per evaluate request

Describe alternatives you've considered (Optional)
Expect ConditionalExpressionEvaluator to handle concurrency.

Additional context
n/a

@dlvenable dlvenable added this to the v2.0 milestone Apr 19, 2022
@dlvenable dlvenable added enhancement New feature or request and removed untriaged labels Apr 19, 2022
@dlvenable dlvenable modified the milestones: v2.0, v2.1 Sep 16, 2022
@dlvenable dlvenable self-assigned this Sep 29, 2022
@dlvenable dlvenable modified the milestones: v2.1, v2.0 Sep 29, 2022
dlvenable added a commit to dlvenable/data-prepper that referenced this issue Sep 29, 2022
…ng a ThreadLocal ParseTreeParser. Resolves opensearch-project#1189

Signed-off-by: David Venable <[email protected]>
dlvenable added a commit that referenced this issue Sep 29, 2022
…ng a ThreadLocal ParseTreeParser. Resolves #1189 (#1840)

Signed-off-by: David Venable <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants