Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When core #1157

Merged
merged 7 commits into from
Mar 9, 2022
Merged

When core #1157

merged 7 commits into from
Mar 9, 2022

Conversation

sbayer55
Copy link
Member

@sbayer55 sbayer55 commented Mar 8, 2022

Description

Added org.opensearch.dataprepper.expression to public context
Added DI support for DataPrepperExpressionParser

Check List

  • New functionality includes testing.
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@sbayer55 sbayer55 requested a review from a team as a code owner March 8, 2022 19:12
dlvenable
dlvenable previously approved these changes Mar 8, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2022

Codecov Report

Merging #1157 (acb0ada) into main (5ecec92) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1157      +/-   ##
============================================
+ Coverage     91.89%   91.91%   +0.01%     
- Complexity      703      704       +1     
============================================
  Files            87       87              
  Lines          2037     2042       +5     
  Branches        171      171              
============================================
+ Hits           1872     1877       +5     
  Misses          122      122              
  Partials         43       43              
Impacted Files Coverage Δ
...in/java/com/amazon/dataprepper/ContextManager.java 100.00% <100.00%> (ø)
...zon/dataprepper/plugin/PluginArgumentsContext.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ecec92...acb0ada. Read the comment docs.

@sbayer55 sbayer55 merged commit 94ca577 into opensearch-project:main Mar 9, 2022
@sbayer55 sbayer55 deleted the when-core branch March 17, 2022 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants