Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload Maven artifacts as part of Release build #1181

Merged
merged 2 commits into from
Mar 14, 2022

Conversation

dlvenable
Copy link
Member

@dlvenable dlvenable commented Mar 12, 2022

Description

The goal of this PR is to upload Maven artifacts to the staging S3 bucket and make them available for download.

  • Created a Gradle task (and project) for uploading Maven artifacts
  • Changed the Maven publish task to use a local build directory (to keep artifacts clean from other Maven artifacts)
  • Fixed the root clean task which was not deleting the build/ directory
  • Updated the Release GitHub Action to upload Maven artifacts
  • Moved all uploading GitHub Actions steps to occur after all the local build parts
  • Refactored the archives Gradle project to share some common conventions with the new Maven project

Issues Resolved

Resolves #1180

Check List

  • New functionality includes testing.
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…ed the Maven publish plugin to publish to the root build directory. Fixed the root clean task to actually delete the build directory.

Signed-off-by: David Venable <[email protected]>
@dlvenable dlvenable requested a review from a team as a code owner March 12, 2022 00:43
@codecov-commenter
Copy link

Codecov Report

Merging #1181 (4aef194) into main (a37d557) will increase coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1181      +/-   ##
============================================
+ Coverage     93.81%   93.99%   +0.18%     
- Complexity     1027     1054      +27     
============================================
  Files           136      139       +3     
  Lines          2925     3014      +89     
  Branches        262      274      +12     
============================================
+ Hits           2744     2833      +89     
  Misses          130      130              
  Partials         51       51              
Impacted Files Coverage Δ
...taprepper/expression/ParseTreeCoercionService.java 100.00% <0.00%> (ø)
...xpression/LiteralTypeConversionsConfiguration.java 100.00% <0.00%> (ø)
...h/dataprepper/expression/UnaryNumericOperator.java 100.00% <0.00%> (ø)
.../expression/UnaryNumericOperatorConfiguration.java 100.00% <0.00%> (ø)
...rch/dataprepper/logstash/mapping/MutateMapper.java 99.11% <0.00%> (+0.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a37d557...4aef194. Read the comment docs.

@dlvenable dlvenable merged commit b29b348 into opensearch-project:main Mar 14, 2022
@dlvenable dlvenable deleted the release-maven-upload branch May 13, 2022 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the Release process to include deploying Maven artifacts to the artifact page
4 participants