MAINT: add otel-proto-common from trace ingestion migration branch #1220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Qi Chen <[email protected]>
Signed-off-by: Qi Chen <[email protected]>
Signed-off-by: Qi Chen <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1220 +/- ##
=========================================
Coverage 93.79% 93.79%
Complexity 1104 1104
=========================================
Files 153 153
Lines 3064 3064
Branches 257 257
=========================================
Hits 2874 2874
Misses 138 138
Partials 52 52 Continue to review full report at Codecov.
|
dlvenable
approved these changes
Mar 21, 2022
sshivanii
reviewed
Mar 23, 2022
| return (List<Object>) OBJECT_MAPPER.readValue(jsonStr, List.class); | ||
| } | ||
|
|
||
| private ExportTraceServiceRequest buildExportTraceServiceRequestFromJsonFile(String requestJsonFileName) throws IOException { |
There was a problem hiding this comment.
Nit: requestJsonFileName may be final.
There was a problem hiding this comment.
Oops! I missed your comment. Will make up in following PRs.
cmanning09
approved these changes
Mar 23, 2022
chenqi0805
deleted the
maint/migrate-otel-proto-common-from-migration-branch
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Qi Chen [email protected]
Description
otel-proto-common is the module includes codec between otel-protobuf and event model
Issues Resolved
Contributes to #1158
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.